Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Defense Elvis] Make sure sidebar doesn't break if there are any missing values in the payload #504

Open
nightsh opened this issue Mar 15, 2020 · 2 comments
Assignees

Comments

@nightsh
Copy link
Member

nightsh commented Mar 15, 2020

In the API payload used to populate the sidebar, we might miss a few values in the case of Defense Elvis manual data.

The task here is to make sure missing data:

  • doesn't break the layout
  • doesn't crash the Ember components
  • doesn't throw any exceptions

If everything works fine, then we can mark this as done. Otherwise, we need to fix values handling within sidebar components.

@georgiana-b
Copy link
Member

In node details response manual data is missing the following fields:

  • For Bid: TEDCANID, isSubcontracted
  • For Lot: description, awardDecisionDate, selectionMethod, estimatedValue
  • For Tender: TEDCNID, description, isEUFunded, isCoveredByGpa, isFrameworkAgreement, procedureType, isDirective
  • For Bidder/Buyer: country

@georgiana-b georgiana-b changed the title Make sure sidebar doesn't break if there are any missing values in the payload [Defense Elvis] Make sure sidebar doesn't break if there are any missing values in the payload Mar 20, 2020
@georgiana-b
Copy link
Member

georgiana-b commented Mar 20, 2020

Just beaware that we are going to remove the Tender Details page as part of #505 so there is need to spend effort on the Tender Details template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants