Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full compatibility with go_amino? #19

Open
adrianbrink opened this issue Nov 11, 2018 · 3 comments
Open

Full compatibility with go_amino? #19

adrianbrink opened this issue Nov 11, 2018 · 3 comments

Comments

@adrianbrink
Copy link

Is amino_rs fully compatible with go-amino?

@liamsi
Copy link
Contributor

liamsi commented Nov 11, 2018

No, not yet. E.g., #15 is missing. And the json encoding isn't part of this implementation at all (only binary encoding).

Also, it does allow everything else that protobuf does (e.g. oneof, encoding floats, maps are not allowed by default in go-amino but they are here).

@liamsi
Copy link
Contributor

liamsi commented Nov 11, 2018

Out of curiosity though: Do you have any use-case that you can't implement with what is there already?

@yihuang
Copy link

yihuang commented Jan 8, 2020

IMO, one of the incompatible issues is the handling of default/empty value, which caused some annoyments in tendermint-rs.
I've described them here: informalsystems/tendermint-rs#103 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants