From 593f085b03a17039ce05d5e2f95768287213a42e Mon Sep 17 00:00:00 2001
From: feedmeapples <aksenov.ro@outlook.com>
Date: Thu, 20 Aug 2020 16:59:48 -0700
Subject: [PATCH 1/3] Create workflows page e2e tests

---
 .../integration/workflow/workflows.spec.js    | 78 +++++++++++++++++++
 1 file changed, 78 insertions(+)
 create mode 100644 cypress/integration/workflow/workflows.spec.js

diff --git a/cypress/integration/workflow/workflows.spec.js b/cypress/integration/workflow/workflows.spec.js
new file mode 100644
index 00000000..7faf9d15
--- /dev/null
+++ b/cypress/integration/workflow/workflows.spec.js
@@ -0,0 +1,78 @@
+/// <reference types="cypress" />
+
+context('Workflow', () => {
+  beforeEach(() => {
+    cy.visit('/namespaces/namespace-web-e2e/workflows');
+  });
+
+  it('navigates to open workflows as default', () => {
+    cy.url().should('include', '&status=OPEN');
+  });
+
+  it('filters workflows by status', () => {
+    cy.get('[data-cy=status-filter]')
+      .click()
+      .find('a')
+      .contains('Open')
+      .click();
+    cy.get('[data-cy=workflow-list]')
+      .find('tr')
+      .should('have.length', 4); // 3 open + 1 requested to be canceled
+
+    cy.wait(1000);
+    cy.get('[data-cy=status-filter]')
+      .click()
+      .find('a')
+      .contains('Closed')
+      .click();
+    cy.get('[data-cy=workflow-list]')
+      .find('tr')
+      .should('have.length', 2); // 1 timed out + 1 terminated
+
+    cy.wait(1000);
+    cy.get('[data-cy=status-filter]')
+      .click()
+      .find('a')
+      .contains('Terminated')
+      .click();
+    cy.get('[data-cy=workflow-list]')
+      .find('tr')
+      .should('have.length', 1);
+
+    cy.wait(1000);
+    cy.get('[data-cy=status-filter]')
+      .click()
+      .find('a')
+      .contains('Timed Out')
+      .click();
+    cy.get('[data-cy=workflow-list]')
+      .find('tr')
+      .should('have.length', 1);
+  });
+
+  it('renders workflow execution details', () => {
+    cy.get('[data-cy=workflow-list]')
+      .find('tr')
+      .eq(3)
+      .should('contain.text', 'wf_open1') // workflow id
+      .should('contain.text', 'e2e_type') // workflow type name
+      .should('contain.text', 'running'); // status
+  });
+
+  it('navigates to workflow details', () => {
+    cy.wait(1000);
+    cy.get('[data-cy=status-filter]')
+      .click()
+      .find('a')
+      .contains('Closed')
+      .click();
+    cy.get('[data-cy=workflow-list]')
+      .find('tr')
+      .eq(0)
+      .find('[data-cy=workflow-link]')
+      .click();
+
+      cy.url().should('include', '/namespaces/namespace-web-e2e/workflows/wf_timedout/');
+      cy.url().should('include', '/summary');
+  });
+});

From 02d61c828b0071e489309a6d64c751e0724144a1 Mon Sep 17 00:00:00 2001
From: feedmeapples <aksenov.ro@outlook.com>
Date: Fri, 21 Aug 2020 09:54:42 -0700
Subject: [PATCH 2/3] move e2e tests to the top of integration

---
 .../integration/workflow/workflows.spec.js    | 78 -------------------
 1 file changed, 78 deletions(-)
 delete mode 100644 cypress/integration/workflow/workflows.spec.js

diff --git a/cypress/integration/workflow/workflows.spec.js b/cypress/integration/workflow/workflows.spec.js
deleted file mode 100644
index 7faf9d15..00000000
--- a/cypress/integration/workflow/workflows.spec.js
+++ /dev/null
@@ -1,78 +0,0 @@
-/// <reference types="cypress" />
-
-context('Workflow', () => {
-  beforeEach(() => {
-    cy.visit('/namespaces/namespace-web-e2e/workflows');
-  });
-
-  it('navigates to open workflows as default', () => {
-    cy.url().should('include', '&status=OPEN');
-  });
-
-  it('filters workflows by status', () => {
-    cy.get('[data-cy=status-filter]')
-      .click()
-      .find('a')
-      .contains('Open')
-      .click();
-    cy.get('[data-cy=workflow-list]')
-      .find('tr')
-      .should('have.length', 4); // 3 open + 1 requested to be canceled
-
-    cy.wait(1000);
-    cy.get('[data-cy=status-filter]')
-      .click()
-      .find('a')
-      .contains('Closed')
-      .click();
-    cy.get('[data-cy=workflow-list]')
-      .find('tr')
-      .should('have.length', 2); // 1 timed out + 1 terminated
-
-    cy.wait(1000);
-    cy.get('[data-cy=status-filter]')
-      .click()
-      .find('a')
-      .contains('Terminated')
-      .click();
-    cy.get('[data-cy=workflow-list]')
-      .find('tr')
-      .should('have.length', 1);
-
-    cy.wait(1000);
-    cy.get('[data-cy=status-filter]')
-      .click()
-      .find('a')
-      .contains('Timed Out')
-      .click();
-    cy.get('[data-cy=workflow-list]')
-      .find('tr')
-      .should('have.length', 1);
-  });
-
-  it('renders workflow execution details', () => {
-    cy.get('[data-cy=workflow-list]')
-      .find('tr')
-      .eq(3)
-      .should('contain.text', 'wf_open1') // workflow id
-      .should('contain.text', 'e2e_type') // workflow type name
-      .should('contain.text', 'running'); // status
-  });
-
-  it('navigates to workflow details', () => {
-    cy.wait(1000);
-    cy.get('[data-cy=status-filter]')
-      .click()
-      .find('a')
-      .contains('Closed')
-      .click();
-    cy.get('[data-cy=workflow-list]')
-      .find('tr')
-      .eq(0)
-      .find('[data-cy=workflow-link]')
-      .click();
-
-      cy.url().should('include', '/namespaces/namespace-web-e2e/workflows/wf_timedout/');
-      cy.url().should('include', '/summary');
-  });
-});

From 3499541beeef26224fd737151b0739d3e80ef88f Mon Sep 17 00:00:00 2001
From: feedmeapples <aksenov.ro@outlook.com>
Date: Mon, 24 Aug 2020 11:55:23 -0700
Subject: [PATCH 3/3] Create summary e2e coverage

---
 client/routes/workflow/summary.vue           | 33 +++++++++-----
 cypress/integration/workflow-summary.spec.js | 48 ++++++++++++++++++++
 2 files changed, 69 insertions(+), 12 deletions(-)
 create mode 100644 cypress/integration/workflow-summary.spec.js

diff --git a/client/routes/workflow/summary.vue b/client/routes/workflow/summary.vue
index 705e9677..4f42b941 100644
--- a/client/routes/workflow/summary.vue
+++ b/client/routes/workflow/summary.vue
@@ -38,15 +38,15 @@
           information may be missing.
         </p>
       </div>
-      <div class="workflow-name">
+      <div class="workflow-name" data-cy="workflow-name">
         <dt>Workflow Name</dt>
         <dd>{{ workflow.workflowExecutionInfo.type.name }}</dd>
       </div>
-      <div class="started-at">
+      <div class="started-at" data-cy="started-at">
         <dt>Started At</dt>
         <dd>{{ workflowStartTime }}</dd>
       </div>
-      <div class="close-time" v-if="workflowCloseTime">
+      <div class="close-time" v-if="workflowCloseTime" data-cy="closed-at">
         <dt>Closed Time</dt>
         <dd>{{ workflowCloseTime }}</dd>
       </div>
@@ -56,6 +56,7 @@
           wfStatus !== undefined &&
             (typeof wfStatus === 'string' ? wfStatus : wfStatus.status)
         "
+        data-cy="workflow-status"
       >
         <dt>Status</dt>
         <dd>
@@ -69,21 +70,25 @@
           </router-link>
         </dd>
       </div>
-      <div class="workflow-result" v-if="resultView">
+      <div class="workflow-result" v-if="resultView" data-cy="workflow-result">
         <dt>Result</dt>
         <dd>
           <data-viewer :item="resultView" :title="workflowId + ' Result'" />
         </dd>
       </div>
-      <div class="workflow-id">
+      <div class="workflow-id" data-cy="workflow-id">
         <dt>Workflow Id</dt>
         <dd>{{ workflowId }}</dd>
       </div>
-      <div class="run-id">
+      <div class="run-id" data-cy="run-id">
         <dt>Run Id</dt>
         <dd>{{ runId }}</dd>
       </div>
-      <div class="parent-workflow" v-if="parentWorkflowRoute">
+      <div
+        class="parent-workflow"
+        v-if="parentWorkflowRoute"
+        data-cy="parent-workflow"
+      >
         <dt>Parent Workflow</dt>
         <dd>
           <router-link :to="parentWorkflowRoute.to">
@@ -91,7 +96,7 @@
           </router-link>
         </dd>
       </div>
-      <div class="task-queue">
+      <div class="task-queue" data-cy="task-queue">
         <dt>Task Queue</dt>
         <dd>
           <router-link
@@ -106,11 +111,11 @@
           </router-link>
         </dd>
       </div>
-      <div class="history-length">
+      <div class="history-length" data-cy="history-length">
         <dt>History Events</dt>
         <dd>{{ workflow.workflowExecutionInfo.historyLength }}</dd>
       </div>
-      <div class="workflow-input">
+      <div class="workflow-input" data-cy="workflow-input">
         <dt>Input</dt>
         <dd>
           <data-viewer
@@ -120,7 +125,11 @@
           />
         </dd>
       </div>
-      <div class="pending-activities" v-if="workflow.pendingActivities">
+      <div
+        class="pending-activities"
+        v-if="workflow.pendingActivities"
+        data-cy="pending-activities"
+      >
         <dt>Pending Activities</dt>
         <dd v-for="pa in workflow.pendingActivities" :key="pa.activityId">
           <detail-list :item="pa" />
@@ -162,7 +171,7 @@ export default {
   },
   created() {
     this.namespaceDescCache = {};
-    this.getWebSettings()
+    this.getWebSettings();
   },
   computed: {
     workflowCloseTime() {
diff --git a/cypress/integration/workflow-summary.spec.js b/cypress/integration/workflow-summary.spec.js
new file mode 100644
index 00000000..41f18f81
--- /dev/null
+++ b/cypress/integration/workflow-summary.spec.js
@@ -0,0 +1,48 @@
+/// <reference types="cypress" />
+
+context('Workflow Summary', () => {
+  beforeEach(() => {
+    cy.visit('/namespaces/namespace-web-e2e/workflows');
+
+    cy.get('[data-cy=status-filter]')
+      .click()
+      .find('a')
+      .contains('Timed Out')
+      .click();
+    cy.get('[data-cy=workflow-list]')
+      .find('tr')
+      .eq(0)
+      .find('[data-cy=workflow-link]')
+      .click();
+  });
+
+  it('renders workflow summary', () => {
+    cy.get('[data-cy=workflow-name]').should('contain.text', 'e2e_type');
+
+    const dateTimeRegex = /\w+\s\w+\s[\d\w]+,\s(\d{1,2}:?){3}\s(am|pm)/;
+    cy.get('[data-cy=started-at]').contains(dateTimeView);
+    cy.get('[data-cy=closed-at]').contains(dateTimeView);
+
+    cy.get('[data-cy=workflow-status]').should('contain.text', 'timedout');
+
+    cy.get('[data-cy=workflow-result]')
+      .should('contain.text', 'retryState')
+      .should('contain.text', 'Timeout');
+
+    cy.get('[data-cy=workflow-id]').should('contain.text', 'wf_timedout');
+
+    const uidRegex = /([\w\d]{4,12}-?){5}/
+    cy.get('[data-cy=run-id]').contains(uidRegex);
+
+    cy.get('[data-cy=parent-workflow]').should('contain.text', 'e2e_type');
+
+    cy.get('[data-cy=task-queue]').should('contain.text', 'e2eQueue');
+
+    cy.get('[data-cy=history-length]').should('contain.text', '3');
+
+    cy.get('[data-cy=workflow-input]')
+      .should('contain.text', '{Harley:Pumpkin!,Joker:Hahahah}')
+      .should('contain.text', 'to infinity and beyond')
+      .should('contain.text', '""');
+  });
+});