Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of Go SDK client.ConnectionOptions.DisableHealthCheck #160

Closed
cretz opened this issue Mar 10, 2022 · 0 comments · Fixed by #175
Closed

Remove use of Go SDK client.ConnectionOptions.DisableHealthCheck #160

cretz opened this issue Mar 10, 2022 · 0 comments · Fixed by #175
Labels
enhancement New feature or request
Milestone
Release v1.16.1

Comments

@cretz
Copy link
Member

cretz commented Mar 10, 2022

Is your feature request related to a problem? Please describe.

See temporalio/temporal#2597. This option is no longer present in the SDK. We need to connect on client instantiation.

Describe the solution you'd like

Remove the option, and make sure that's ok for tctl.
@cretz cretz added the enhancement New feature or request label Mar 10, 2022
@feedmeapples feedmeapples mentioned this issue Apr 19, 2022
Merged
@feedmeapples feedmeapples added this to the Release v1.16.1 milestone Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Release v1.16.1
Development

Successfully merging a pull request may close this issue.

Decouple versioning from Temporal temporalio/tctl
2 participants
@cretz @feedmeapples