Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worker versioning support #322

Closed
Tracked by #294
bergundy opened this issue Jul 5, 2023 · 0 comments
Closed
Tracked by #294

Worker versioning support #322

bergundy opened this issue Jul 5, 2023 · 0 comments
Assignees
Labels
Feature New feature or request
Milestone

Comments

@bergundy
Copy link
Member

bergundy commented Jul 5, 2023

  • Add UpdateWorkerBuildIdCompatibility gRPC call.
  • proto: /temporal.api.workflowservice.v1.WorkflowService/UpdateWorkerBuildIdCompatibility
    In args: (from GO):
type UpdateWorkerBuildIdCompatibilityRequest struct {
	Namespace string `protobuf:"bytes,1,opt,name=namespace,proto3" json:"namespace,omitempty"`
	// Must be set, the task queue to apply changes to. Because all workers on a given task queue
	// must have the same set of workflow & activity implementations, there is no reason to specify
	// a task queue type here.
	TaskQueue string `protobuf:"bytes,2,opt,name=task_queue,json=taskQueue,proto3" json:"task_queue,omitempty"`
	// Types that are valid to be assigned to Operation:
	//	*UpdateWorkerBuildIdCompatibilityRequest_AddNewBuildIdInNewDefaultSet
	//	*UpdateWorkerBuildIdCompatibilityRequest_AddNewCompatibleBuildId
	//	*UpdateWorkerBuildIdCompatibilityRequest_PromoteSetByBuildId
	//	*UpdateWorkerBuildIdCompatibilityRequest_PromoteBuildIdWithinSet
	//	*UpdateWorkerBuildIdCompatibilityRequest_MergeSets_
	Operation isUpdateWorkerBuildIdCompatibilityRequest_Operation `protobuf_oneof:"operation"`
}

This call should be done to update worker buildID compatibility:

err := tc.UpdateWorkerBuildIdCompatibility(context.Background(), &temporalClient.UpdateWorkerBuildIdCompatibilityOptions{
	TaskQueue: wi[i].TaskQueue,
	Operation: &temporalClient.BuildIDOpAddNewCompatibleVersion{
		BuildID: wi[i].Options.BuildID,
	},
})
@bergundy bergundy transferred this issue from temporalio/features Jul 5, 2023
@bergundy bergundy changed the title PHP Worker versioning Jul 5, 2023
@bergundy bergundy changed the title Worker versioning Worker versioning support Jul 5, 2023
@wolfy-j wolfy-j added the Feature New feature or request label Jul 11, 2023
@roxblnfk roxblnfk added this to the 2.8.0 milestone Dec 12, 2023
@sync-by-unito sync-by-unito bot closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants