Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception for Update #2069

Closed
drewhoskins-temporal opened this issue May 18, 2024 · 1 comment · Fixed by #2172
Closed

Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception for Update #2069

drewhoskins-temporal opened this issue May 18, 2024 · 1 comment · Fixed by #2172

Comments

@drewhoskins-temporal
Copy link

So that users only have to catch one predictable exception
Closed
8 tasks
@drewhoskins-temporal drewhoskins-temporal changed the title Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in an SDK Timeout exception for Update May 18, 2024
@cretz cretz mentioned this issue May 20, 2024
Merged
@cretz
Copy link
Member

cretz commented Jun 5, 2024

See temporalio/features#483 (comment) for implementation details

@Quinn-With-Two-Ns Quinn-With-Two-Ns mentioned this issue Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrap GRPC::CANCELED and DEADLINE_EXCEEDED in new exception type Quinn-With-Two-Ns/sdk-java
2 participants
@cretz @drewhoskins-temporal