Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support ignoring invalid server certificates #378

Open
cretz opened this issue Aug 18, 2022 · 0 comments
Open

[Feature Request] Support ignoring invalid server certificates #378

cretz opened this issue Aug 18, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@cretz
Copy link
Member

cretz commented Aug 18, 2022

Is your feature request related to a problem? Please describe.

In Go we can use InsecureSkipVerify on tls.Config and in Java we can call setUseInsecureTrustManager, but there is no equivalent in Core.

Describe the solution you'd like

We need some kind of ignore_invalid_server_cert boolean. I don't think we want to just call it insecure because that implies a lot. And I could see one day people want more control over which errors they ignore on invalid server, but I think this would solve most needs for now.

Other users wanted to do similar, e.g. hyperium/tonic#891 (comment). https://github.com/hyperium/tonic/blob/master/examples/src/tls/client_rustls.rs is an example of custom TLS. We might have to use something like Endpoint.connect_with_connector and make our own connector. Or maybe we can upstream something to tonic.

@cretz cretz added the enhancement New feature or request label Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant