-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make start_update users aware that it's synchronous w/ worker. #469
Comments
I like this required-wait-stage approach and we can remove the requirement and default to durable on-admitted if/when it becomes available. If there's no objection from others, would love to make this the way in all SDKs There is a set of pending work for updates in SDKs once internal metering is improved that this work can be a part of. This issue, #431, and #432 should all be knocked out by each SDK (some are already done). |
Closing since afaik this is done. @drewhoskins-temporal please re-open if you disagree. |
Is your feature request related to a problem? Please describe.
By default,
start_update
waits until the (often remote) worker accepts it.It misleads customers into thinking it's fully async, as
start_activity
andstart_workflow
are. Customers won’t be aware that the remote worker blocks this call and might inadvertently take a dependency on a worker, for example, that has a lower availability level than the service calling it. Such a mistake would cause an outage to a critical service.In the future, we want users to be able to choose durable-on-admitted. Removing the default here would make space for that.
Describe the solution you'd like
We decided to force customers to explicitly pass in a flag saying what’s being awaited. (e.g. start_update(wait_for_stage=ACCEPTED/COMPLETED)) and then if they don’t provide it.
We should also make sure the comments are clear that the remote worker must be present for the operation to work.
Additional context
Per-SDK Tickets
update start
in addition toupdate execute
cli#597The text was updated successfully, but these errors were encountered: