Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken preview appearance and server errors on theme download due to slow themes build process #6108

Closed
Dimitar-Goshev opened this issue Oct 29, 2020 · 5 comments · Fixed by telerik/kendo-themes#2040
Assignees
Labels

Comments

@Dimitar-Goshev
Copy link
Contributor

Bug report

When creating a theme through ThemeBuilder, there is a themecompiler request, whose response takes more than two minutes. Waiting so long for a response is not acceptable and also it is a regressions since this behavior was not reproducible before R3 2020. Also there is no loading indicator showing that we are waiting for something to happen.

There are several scenarios to reproduce an issue caused by slow build process.

Reproduction of the problem 1

  1. Go to https://demos.telerik.com/kendo-ui/grid/index
  2. Expand Edit dropdown and select "Edit in Theme Builder"

Current behavior

ThemeBuilder preview loads with no content. After several minutes the preview appears without styles.

Expected/desired behavior

The Preview shows a Grid for editing.

Reproduction of the problem 2

  1. Go to https://themebuilder.telerik.com/kendo-ui
  2. Select Start Theming
  3. Click Create
  4. After the preview loads, expand the dropdown, deselect Menu and collapse the dropdown
  5. Click Download, type theme name and click OK

Current behavior

Server error:

iisnode encountered an error when processing the request.

HRESULT: 0x6d
HTTP status: 500
HTTP subStatus: 1013
HTTP reason: Internal Server Error
You are receiving this HTTP 200 response because system.webServer/iisnode/@devErrorsEnabled configuration setting is 'true'.

Expected/desired behavior

No error, custom theme is downloaded

Reproduction of the problem 3

  1. Go to https://themebuilder.telerik.com/kendo-ui
  2. Select Start Theming
  3. Unselect Breadcrumb and Tabstrip (or something else, e.g. Menu)
  4. Click Create
  5. After swatches load, immediately select Download, type theme name and click OK

NOTE: When there are deselected widgets, it may take 4 minutes to load the preview. Even then, the widgets are severely corrupt.
However, if we leave Tabstrip and Breadcrumb selected, this doesn't seem to happen.

Current behavior

Server error:

iisnode encountered an error when processing the request.

HRESULT: 0x6d
HTTP status: 500
HTTP subStatus: 1013
HTTP reason: Internal Server Error
You are receiving this HTTP 200 response because system.webServer/iisnode/@devErrorsEnabled configuration setting is 'true'.

Expected/desired behavior

No error, custom theme is downloaded

Environment

  • Kendo UI version: 2020.3.915
  • Browser: all
@Gardens18
Copy link

Any update on this issue ?

@Dimitar-Goshev
Copy link
Contributor Author

@Gardens18 We are currently working on fixing the issue. We will update its status, once done.

@Dimitar-Goshev Dimitar-Goshev added FP: In Development Sync status with associated Feedback Item and removed FP: Unplanned Sync status with associated Feedback Item labels Nov 5, 2020
@kendo-bot kendo-bot added the FP: Planned Sync status with associated Feedback Item label Nov 5, 2020
@kendo-bot kendo-bot added FP: Completed Sync status with associated Feedback Item and removed FP: Planned Sync status with associated Feedback Item labels Nov 6, 2020
@Dimitar-Goshev Dimitar-Goshev removed the FP: In Development Sync status with associated Feedback Item label Nov 9, 2020
@StoyanGoranov StoyanGoranov reopened this Feb 19, 2021
@StoyanGoranov StoyanGoranov removed the FP: Completed Sync status with associated Feedback Item label Feb 19, 2021
@StoyanGoranov
Copy link

Reopened after a report in 1507626

@StoyanGoranov
Copy link

Steps for reproduction of the issue provided by client:

  1. Go to Themebuilder (https://themebuilder.telerik.com/)
  2. Select Kendo UI
  3. Import Theme
  4. Upload file attached to ticket (scss)
  5. Click Download

I haven't been able to reproduce this issue.

@ag-petrov ag-petrov removed the jQuery1 label Nov 30, 2022
@Dimitar-Goshev
Copy link
Contributor Author

Closing it due to not reproducing the issue.

@github-actions github-actions bot added the FP: Completed Sync status with associated Feedback Item label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants