Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass compilebreak: Undefined variable $input-bg in kendo-theme-default (checkbox) after updating from v4.23.0 to v4.24.0 #1973

Closed
sceee opened this issue Oct 14, 2020 · 2 comments · Fixed by #2040
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@sceee
Copy link

sceee commented Oct 14, 2020

Describe the bug
After updating kendo-theme-default from ^4.23.0 -> ^4.24.0, the following Sass compilebreak occurred:

ERROR in ./src/common/kendo.scss (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js!./src/common/kendo.scss)
Module build failed (from ./node_modules/sass-loader/dist/cjs.js):
SassError: Undefined variable.
   ╷
12 │ $checkbox-bg: $input-bg !default;
   │               ^^^^^^^^^
   ╵
  node_modules\@progress\kendo-theme-default\scss\checkbox\_variables.scss 12:15  @import
  node_modules\@progress\kendo-theme-default\scss\checkbox\_index.scss 9:9        @import
  node_modules\@progress\kendo-theme-default\scss\adaptive\_index.scss 7:9        @import
  node_modules\@progress\kendo-theme-default\scss\grid\_index.scss 7:9            @import
  src\common\kendo.scss 5:9                                                       root stylesheet

To reproduce
Steps to reproduce the behavior:

  1. Use the following code to embed kendo themes in a kendo.scss file:
@import "@progress/kendo-theme-default/scss/grid/_index.scss";
@import "@progress/kendo-theme-default/scss/spreadsheet/_index.scss";
@import "@progress/kendo-theme-default/scss/dataviz/_index.scss";
@import "@progress/kendo-theme-default/scss/editor/_index.scss";
  1. Compile it using webpack with sass-loader
  2. Compilebreak mentioned above occurs - I feel it is resulting from 1b9bf25

Note that the code compiles successfully in v4.23.0.

Expected behavior
Variable is defined, compile still works

Screenshots
N/A

Affected package (please remove the unneeded items)

  • theme-default

Affected suites (please remove the unneeded items)

  • Kendo UI for React

Affected browsers (please remove the unneeded items)

  • Not Applicable

Build system information (please remove the unneeded items)

  • OS: Windows
  • Node version: v12.19.0
  • NPM version: 6.14.8

Additional context
As mentioned, it feels it was introduced by 1b9bf25.

@sceee sceee added the Bug Something isn't working label Oct 14, 2020
@joneff joneff added this to the 2021.1 milestone Nov 4, 2020
@joneff joneff self-assigned this Nov 4, 2020
@joneff
Copy link
Contributor

joneff commented Nov 4, 2020

Targeted in related pull request. Depending on when the PR gets reviewed, we can have it in dev channel as soon as tomorrow and in stable channel some time after.

@joneff
Copy link
Contributor

joneff commented Nov 5, 2020

The themes are out

 - @progress/[email protected]
 - @progress/[email protected]
 - @progress/[email protected]
 - @progress/[email protected]
 - @progress/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants