Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split scss/input styles (extract components) #1795

Closed
joneff opened this issue Aug 28, 2020 · 1 comment · Fixed by #1919 or #2040
Closed

Split scss/input styles (extract components) #1795

joneff opened this issue Aug 28, 2020 · 1 comment · Fixed by #1919 or #2040
Labels
C:Forms Enhancement New feature of an existing functionality or an improvement of an existing functionality.
Milestone

Comments

@joneff
Copy link
Contributor

joneff commented Aug 28, 2020

Currently, the styles for floating label are inside scss/input files and should be extracted in their separate module. The module should also be included as a dependency in the related components.

On a related note: k-fieldset styles are also in scss/input and should probably be moved to scss/forms.

Finally, looking at scss/forms, I am seeing styles for bootstrap forms. Those must definitely be extracted to a separate module. Material, per se, is not compatible with Bootstrap and the bootstrap-forms module will not be present there. At the very least, for v5 of the themes, we may consider re-evaluating our integration with Bootstrap.

@joneff joneff added Enhancement New feature of an existing functionality or an improvement of an existing functionality. C:Forms labels Aug 28, 2020
@joneff joneff added this to the 2020.3 milestone Aug 28, 2020
@joneff joneff modified the milestones: 2020.3, 2021.1 Sep 14, 2020
@joneff
Copy link
Contributor Author

joneff commented Dec 17, 2020

Minus the bootstrap forms, the rest is done

@joneff joneff closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Forms Enhancement New feature of an existing functionality or an improvement of an existing functionality.
Projects
None yet
1 participant