[Bug] The KendoReact dependencies are not added when create-kendoreact-app is used

[vveesseelliinnaa]

Public item - https://feedback.telerik.com/kendo-react-ui/1561911

I'm submitting a...

• Regression report

Current behavior

The dependencies for the KendoReact packages are not added tot he package.json file when a project is scaffolded with create-kendoreact-app.

Expected behavior

The created project has to contain references for all KendoReact packages.

Minimal reproduction of the problem with instructions

1. Follow the steps form this article - https://www.telerik.com/kendo-react-ui/components/getting-started/create-kendoreact-app/#toc-create-kendoreact-app
2. Open the created project and observe the almost empty package.json file:

{
  "name": "my-test-ckra",
  "version": "0.1.0",
  "private": true,
  "dependencies": {
    "cra-template-kendo-sass": "file:../../../.npm/_npx/b702a42a1b530dca/node_modules/cra-template-kendo-sass",
    "react": "^18.3.1",
    "react-dom": "^18.3.1",
    "react-scripts": "5.0.1"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "eject": "react-scripts eject"
  },
  "eslintConfig": {
    "extends": [
      "react-app",
      "react-app/jest"
    ]
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  },
  "devDependencies": {
    "sass": "^^1.68.0"
  }
}

[joelparkerhenderson]

Thanks all for looking into this. What's the plan for an automated build test? Meaning, an automated test such that when a new Kendo release is being prepared, some automatic process happens that tries at least the basic test of "Does it set up?"

[silviyaboteva]

Hello @joelparkerhenderson,

Using the latest v0.6.0 of the create-kendoreact-app package, the project is scaffolded, the dependencies are populated in the "dependencies" object of the package.json file, and the application builds and runs without errors. We have tested all configurations via the wizard and confirm that the produced application runs as expected.

So, the solution is to upgrade the create-kendoreact-app package with the following command and test to scaffold a new project once again:

npm install -g [email protected]

Please note that in case you choose to use SASS, there is the following warning:

Deprecation The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.

This is expected and it won't break the application. Currently, the Kendo Themes are built on Node Sass syntax, but we already work on the Dart Sass migration (for reference: telerik/kendo-themes#4104) and once we release it, it will resolve the warnings related to Sass.

Up to the question related to the automated build tests. We do have an automated build that checks if the project is created and builds successfully. This build runs daily.

I hope that the above information helps.

I'm closing this issue and the one in our Feedback Portal as resolved.

[joelparkerhenderson]

Still not fixed-- please reopen.

The warnings now show:

Installing template dependencies using npm...
npm WARN deprecated [email protected]: This package is no longer supported.
npm WARN deprecated [email protected]: This package is no longer supported.
npm WARN deprecated [email protected]: This package is no longer supported.

[silviyaboteva]

Hello @joelparkerhenderson,

From the code snippet, I noticed that these are warnings the will not prevent the application from building successfully. Can you confirm that the app builds and runs successfully without errors?

I did some further testing but I was not able to reproduce these on my end. So, I researched these packages and found out that they are coming from @mapbox/node-pre-gyp NPM package and they already have an issue opened on the matter: mapbox/node-pre-gyp#877. You can track the status there. Once they merge the PRs of the dependabot, the warnings should disappear.

As a side note, can you please provide the configuration steps that are passed to the wizard when creating a new application and the output package.json file so we can investigate further.

[joelparkerhenderson]

This issue still is set as "Closed" which means I can't add more info-- can you reopen it?