From 01ff0a04c510ff7ef73a5c452e52966ea0925860 Mon Sep 17 00:00:00 2001 From: Arturo Date: Wed, 31 May 2023 23:11:47 +0200 Subject: [PATCH 1/7] fix(icons): polish after lib update --- .../__snapshots__/collapsible.spec.ts.snap | 2 +- .../components/collapsible/collapsible.css | 5 +- .../components/collapsible/collapsible.tsx | 18 +++-- .../src/components/data-grid/data-grid.tsx | 9 ++- .../components/date-picker/date-picker.css | 4 +- .../components/date-picker/date-picker.tsx | 9 ++- .../dropdown-select/dropdown-select.css | 2 +- .../dropdown-select/dropdown-select.e2e.ts | 2 +- .../dropdown-select/dropdown-select.spec.ts | 6 +- .../dropdown-select/dropdown-select.tsx | 5 +- .../src/components/dropdown/dropdown.css | 2 +- .../src/components/dropdown/dropdown.tsx | 2 +- .../__snapshots__/pagination.spec.ts.snap | 16 ++--- .../src/components/pagination/pagination.css | 10 +-- .../src/components/pagination/pagination.tsx | 70 ++++--------------- .../sidebar-nav-collapsible.spec.ts.snap | 4 +- .../sidebar-nav-collapsible.tsx | 2 +- .../__snapshots__/sidebar-nav.spec.ts.snap | 14 ++-- .../components/sidebar-nav/sidebar-nav.tsx | 2 +- .../components/button/Button.stories.mdx | 16 ++--- .../components/data-grid/DataGrid.stories.mdx | 28 -------- 21 files changed, 78 insertions(+), 150 deletions(-) diff --git a/packages/components/src/components/collapsible/__snapshots__/collapsible.spec.ts.snap b/packages/components/src/components/collapsible/__snapshots__/collapsible.spec.ts.snap index 5d58e9fb91..36713f2373 100644 --- a/packages/components/src/components/collapsible/__snapshots__/collapsible.spec.ts.snap +++ b/packages/components/src/components/collapsible/__snapshots__/collapsible.spec.ts.snap @@ -6,7 +6,7 @@ exports[`TextField should match snapshot 1`] = `

diff --git a/packages/components/src/components/pagination/__snapshots__/pagination.spec.ts.snap b/packages/components/src/components/pagination/__snapshots__/pagination.spec.ts.snap index 8fd340aef4..d8e6b7c934 100644 --- a/packages/components/src/components/pagination/__snapshots__/pagination.spec.ts.snap +++ b/packages/components/src/components/pagination/__snapshots__/pagination.spec.ts.snap @@ -18,24 +18,16 @@ exports[`pagination should match snapshot 1`] = ` / 1 diff --git a/packages/components/src/components/pagination/pagination.css b/packages/components/src/components/pagination/pagination.css index cc69427ea0..dde07d7930 100644 --- a/packages/components/src/components/pagination/pagination.css +++ b/packages/components/src/components/pagination/pagination.css @@ -97,11 +97,11 @@ button:not(:disabled) { cursor: pointer; } button:not(:disabled) svg { - stroke: var(--stroke-svg); + color: var(--stroke-svg); } button:disabled svg { - stroke: var(--telekom-color-text-and-icon-disabled); + color: var(--telekom-color-text-and-icon-disabled); } button:not(:disabled):hover { @@ -109,14 +109,14 @@ button:not(:disabled):hover { z-index: 1; } button:not(:disabled):hover svg { - stroke: var(--color-hover); + color: var(--color-hover); } button:not(:disabled):active { border-color: var(--color-active); z-index: 1; } button:not(:disabled):active svg { - stroke: var(--color-active); + color: var(--color-active); } /* Hide Borders option */ @@ -153,7 +153,7 @@ button:not(:disabled):active svg { @media screen and (forced-colors: active), (-ms-high-contrast: active) { button:not(:disabled) svg { - stroke: var(--stroke-svg-high-contrast); + color: var(--stroke-svg-high-contrast); } } diff --git a/packages/components/src/components/pagination/pagination.tsx b/packages/components/src/components/pagination/pagination.tsx index 8c5c9e2bfd..28ef043342 100644 --- a/packages/components/src/components/pagination/pagination.tsx +++ b/packages/components/src/components/pagination/pagination.tsx @@ -37,6 +37,8 @@ import { emitEvent } from '../../utils/utils'; export type PaginationEventDirection = 'FIRST' | 'PREVIOUS' | 'NEXT' | 'LAST'; +const DEFAULT_ICON_SIZE = 20; + const name = 'pagination'; @Component({ tag: 'scale-pagination', @@ -207,19 +209,10 @@ export class Pagination { onClick={() => this.goFirstPage()} aria-label={this.ariaLabelFirstPage} > - - - + diff --git a/packages/components/src/components/sidebar-nav-collapsible/__snapshots__/sidebar-nav-collapsible.spec.ts.snap b/packages/components/src/components/sidebar-nav-collapsible/__snapshots__/sidebar-nav-collapsible.spec.ts.snap index 181252d728..82c0129fae 100644 --- a/packages/components/src/components/sidebar-nav-collapsible/__snapshots__/sidebar-nav-collapsible.spec.ts.snap +++ b/packages/components/src/components/sidebar-nav-collapsible/__snapshots__/sidebar-nav-collapsible.spec.ts.snap @@ -6,7 +6,7 @@ exports[`SidebarNavCollapsible emitter exit handleKeydown if event metaKey 1`] =