Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add closeButtonTitle props to modal components #995

Merged
merged 2 commits into from
Apr 14, 2022
Merged

feat: add closeButtonTitle props to modal components #995

merged 2 commits into from
Apr 14, 2022

Conversation

maomaoZH
Copy link
Collaborator

No description provided.

@maomaoZH maomaoZH requested a review from nowseemee as a code owner April 13, 2022 19:14
@render
Copy link

render bot commented Apr 13, 2022

Your Render PR Server URL is https://scale-storybook-staging-pr-995.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-c9bi26397ej05cn821d0.

@maomaoZH maomaoZH requested a review from acstll April 13, 2022 19:14
@maomaoZH maomaoZH linked an issue Apr 13, 2022 that may be closed by this pull request
Tooltip for closing modal window #771
Closed
acstll
acstll requested changes Apr 14, 2022
View reviewed changes
Copy link
Collaborator

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to update Storybook 🤓🙏

Thank you!

@maomaoZH
Copy link
Collaborator Author

maomaoZH commented Apr 14, 2022 •
edited
Loading

I think you forgot to update Storybook 🤓🙏

Indeed! I just pushed an update. Thanks for reviewing!

@acstll acstll merged commit 1555fe3 into main Apr 14, 2022
@acstll acstll deleted the feat/issue-771-add-closeButtonTitle-in-modal branch April 14, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acstll acstll acstll approved these changes

@nowseemee nowseemee Awaiting requested review from nowseemee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip for closing modal window
2 participants
@maomaoZH @acstll