Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove title attribute from modal window #852

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

maomaoZH
Copy link
Collaborator

@maomaoZH maomaoZH commented Feb 7, 2022

I have removed the title attribute because we already have aria-label attribute.

@maomaoZH maomaoZH requested a review from nowseemee as a code owner February 7, 2022 07:12
@maomaoZH maomaoZH linked an issue Feb 7, 2022 that may be closed by this pull request
@nowseemee nowseemee merged commit 3e4213b into main Feb 8, 2022
@nowseemee nowseemee deleted the bug/issue#666-modal-window-title branch February 8, 2022 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scale Modal - Heading shown as ToolTip anywhere
2 participants