Button Bug Issue #645

[ChrisPaj]

Button - Link element auto sets download="false" #645

[render]

Your Render PR Server URL is https://scale-storybook-staging-pr-648.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-c5sekunh8vl24jbbsokg.

[acstll]

@nowseemee @ChrisPaj I think this is not quite fixed yet 🤪

The download attribute mainly expects a string to set the file name of the download. So in the first place its type should be string. In any case, not default to false.

According to the docs in MDN, it could also be present without a value (acting like a boolean attribute).

I would make the prop type string | true (if that works), and then see how Stencil handles that. If it gets too tricky, I would make it only a string and then check for "true" (as a string). The end result must be either:

<!-- a string value -->
<a href="..." download="some-value.pdf">Label</a>
<!-- or no value (boolean) -->
<a href="..." download>Label</a>