Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkbox #543

Merged
merged 18 commits into from
Sep 1, 2021
Merged

Fix checkbox #543

merged 18 commits into from
Sep 1, 2021

Conversation

oddcelot
Copy link
Collaborator

  • fixes focus state
  • disabled defaults to false

@oddcelot oddcelot requested a review from eeegor as a code owner August 26, 2021 08:06
@oddcelot oddcelot self-assigned this Aug 26, 2021
@oddcelot oddcelot requested a review from acstll August 26, 2021 08:06
@oddcelot oddcelot added the bug Something isn't working label Aug 26, 2021
@render
Copy link

render bot commented Aug 26, 2021

Your Render PR Server URL is https://scale-storybook-staging-pr-543.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-c4jkn69g7hp0j40tljj0.

@acstll
Copy link
Collaborator

acstll commented Aug 26, 2021

@oddcelot the unit tests are not passing 🔥

@oddcelot
Copy link
Collaborator Author

oddcelot commented Aug 27, 2021 •
edited
Loading

so this fixes some issues with the agent states
while doing this a complete overhaul of the component was deemed necessary
some nice additions:

  • indeterminate icon now also for neutral edition ➖
  • implemented shadow parts for all components ⚙
  • styling done via shadow parts selector 🌈
  • resolved specificity issues for agent states 🔬
  • for the future: enabling the shadow DOM should be easy (only remove the scale-checkbox from css) 🔮
  • added proper indeterminate state resolution and click behavior when changing from indeterminate to fully checked ☑️
  • added some more event detail for the change event 🔍

@oddcelot oddcelot force-pushed the fix/checkbox branch 2 times, most recently from 547b09e to 88d084a Compare August 31, 2021 08:08
oddcelot and others added 14 commits August 31, 2021 11:15
@oddcelot
fix(checkbox): fix focus styles
b620729 
also cleanup comments and redundant styles
@oddcelot
refactor(checkbox): set prop disabled default to false
88bbf89
@marvinLaubenstein @oddcelot
fix(checkbox): accessibility
6f26d1f
@oddcelot
refactor(checkbox): complete overhaul for checkbox
769e451
@oddcelot
fix(switch): make checked prop mutable
142cf28
@oddcelot
fix(checkbox): make checked and indeterminate mutable
cfc4c3a
@oddcelot
fix(checkbox): align label with checkbox
4a23435
@oddcelot
fix(data-grid): eval checkbox value as boolean
86d329c
@oddcelot
refactor(checkbox): adjust tests and default props
74fa071
@oddcelot
refactor(data-grid/checkbox): adjust layout for selectable rows
e28225d
@oddcelot
refactor(checkbox-group): improve evaluation and update mechanics
491a897
@oddcelot
refactor(checkbox): adjust styling and prop mutability
71a8a0c 
also update tests and props for switch/data-grid/checkbox-group
@oddcelot
chore: update formatting
3d542e5
@nowseemee @oddcelot
test(checkbox): update visual snapshots
8e04e4c
@nowseemee nowseemee merged commit c489496 into main Sep 1, 2021
@nowseemee nowseemee deleted the fix/checkbox branch September 1, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeegor eeegor Awaiting requested review from eeegor

@acstll acstll Awaiting requested review from acstll

Assignees

@oddcelot oddcelot

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oddcelot @acstll @nowseemee @marvinLaubenstein