feat: striped tables #489
Merged
feat: striped tables #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also noticed some empty rulesets in some of the CSS files. |
|
Thank you @Lalaluka! I'm checking this out and testing it today, looks perfect at first look. For the variable name, here is the convention I drafted some time ago but didn't make it in the docs:
Based on this, I would name it |
acstll
reviewed
Aug 2, 2021
packages/storybook-vue/stories/3_components/table/Table.stories.mdx
Outdated
Show resolved
Hide resolved
packages/storybook-vue/stories/3_components/table/Table.stories.mdx
Outdated
Show resolved
Hide resolved
|
Good work. I would like to thank both of you. :) |
Kutlovcidenis
added a commit
that referenced
this pull request
Aug 4, 2021
* main: (56 commits) feat: striped tables (#489) test(visual): update snapshots (#494) Revert "docs(storybook): separate header from shell" (#493) docs(storybook): app-shell and app-header distinction (#471) build: build project build: build test: adapt snapshot refactor: functions refactor: simplify setIconPositionProp() refactor: format; lint fix: also allow customized icons refactor: make functions more robust refactor: adapt snapshots; format; lint feat: add media query for high contrast feat: storybook aria-translation feat: accessibility story toggle group fix: colorScheme default value feat: change translation features feat: add accessibility story to toggle-button feat: aria translation ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 🧑💻,
Here is the Implementation of #483
I added the prop
stripedto the tables adapting the naming of Bootstrap.It colors every second Row with grey 0. And can be changed through the css-variable:
--background-secondary-tbodyI'm not that happy with the Variable name (just changed it again) would --background-striped better?
Also added to Visual Tests, Storybook and Sketch Library :)
Another thing the Screenshot from @Kaawo also had vertical borders. Those are also not present in the Table implementation atm