Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disabled tabs #484

Merged
merged 5 commits into from
Aug 10, 2021
Merged

feat: disabled tabs #484

merged 5 commits into from
Aug 10, 2021

Conversation

Lalaluka
Copy link
Contributor

Related to #467
Implements Tabs that are disableable through the disabled attribute.
Usage examples are added to the Storybook and Visual Tests.

I also took a look at the keyboard navigation and it should work as intended (Arrow Keys, END, HOME).

@Lalaluka Lalaluka requested a review from eeegor as a code owner July 29, 2021 18:29
@acstll
Copy link
Collaborator

acstll commented Aug 2, 2021

Also taking a look at this… 👀

Copy link
Collaborator

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one small thing I found (left a comment), other than that this is perfect.

Thanks so much. (Sorry that it took me so long to test it and do the actual review.)

@Lalaluka Lalaluka requested a review from acstll August 10, 2021 07:10
@acstll acstll merged commit ed12fd1 into telekom:main Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants