fix: events and checked
prop in Radio
#426
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current radio button implementation, the
scaleChange
event is being fired only once. This makes it impossible to hook with framework's state/models.This PR fixes that.
(It also fixes the
click
event being fired twice while clicking on the label.)Why
input[type="radio"]
elements only firechange
events after user input and only when being actuallychecked
, not unchecked (there is nochange
event while being unchecked). Since our component relies on thischange
event to update itschecked
property, this remainstrue
forever after the firstchange
event. And, since thescaleChange
event gets fired using a watcher on this samechecked
prop, it fires only once: the one timechecked
changes fromfalse
totrue
.Some inspiration: https://github.com/shoelace-style/shoelace/blob/next/src/components/radio/radio.ts