fix(date-picker): sync code and figma #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
nowseemee
force-pushed
the
datepicker-styles
branch
2 times, most recently
from
0c1cb38 to
8754d75
Compare
nowseemee
force-pushed
the
datepicker-styles
branch
from
8754d75 to
1e9637f
Compare
|
i think the top-padding here should be 16px (and maybe the bottom padding/margin needs to be adjusted) |
Also not sure if this is expected but there is a close icon that can be tabbed to (otherwise it is invisible) and previously it was on the top right, now on the top left |
nowseemee
force-pushed
the
datepicker-styles
branch
from
e67dcc7 to
1c757f8
Compare
nowseemee
force-pushed
the
datepicker-styles
branch
from
1c757f8 to
d90891b
Compare
Co-authored-by: nowseemee <[email protected]>
nowseemee
force-pushed
the
datepicker-styles
branch
from
b95b8d6 to
ec5549b
Compare
Co-authored-by: nowseemee <[email protected]>
felix-ico
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@felix-ico could you take a look at this, please?