Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding accessibility title #1830

Merged
merged 2 commits into from
May 16, 2023
Merged

feat: adding accessibility title #1830

merged 2 commits into from
May 16, 2023

Conversation

marvinLaubenstein
Copy link
Collaborator

fix: #1713

@netlify
Copy link

netlify bot commented May 11, 2023 •
edited
Loading

✅ Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 2189ed9
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/646340efa659d90008ebfd7f
😎 Deploy Preview https://deploy-preview-1830--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot mentioned this pull request May 11, 2023
Closed
@ayeshaa-m
Copy link
Contributor

looks good to me. I see we need canvas control.

@github-actions github-actions bot mentioned this pull request May 16, 2023
Closed
@marvinLaubenstein marvinLaubenstein merged commit 52b2023 into main May 16, 2023
@marvinLaubenstein marvinLaubenstein deleted the feat/loading-spinner-a11y_1713 branch May 16, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayeshaa-m ayeshaa-m ayeshaa-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading Spinner only has English default text for screen reader (Loading)
2 participants
@marvinLaubenstein @ayeshaa-m