Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support for prop hides label in iconNavigation and alternate tex… #1785

Merged
merged 2 commits into from
May 5, 2023

Conversation

ayeshaa-m
Copy link
Contributor

support for prop hides label in iconNavigation and alternate text through translation aria labe

@ayeshaa-m ayeshaa-m requested a review from felix-ico May 4, 2023 11:34
@ayeshaa-m ayeshaa-m requested review from acstll and nowseemee as code owners May 4, 2023 11:34
@ayeshaa-m ayeshaa-m linked an issue May 4, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit bd91370
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/6454bf3ba6be8d0007587210
😎 Deploy Preview https://deploy-preview-1785--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Collaborator

@nowseemee nowseemee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks a lot!

could you add usage examples to the fixtures here and here, please?

@felix-ico felix-ico merged commit 4d5bda4 into main May 5, 2023
@felix-ico felix-ico deleted the fix/scale-telekom-header-1745 branch May 5, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scale-telekom-header-data-back-compat hides label in iconNavigation
3 participants