Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tab-header): focus problems (#1372) #1729

Merged
merged 2 commits into from
Apr 17, 2023
Merged

fix(tab-header): focus problems (#1372) #1729

merged 2 commits into from
Apr 17, 2023

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Apr 17, 2023

Should fix #1372 for good 🙏

Removes the need for the recently-added autoFocus prop. (I'm intentionally not deprecating it.)

Please @felix-ico take a look after CI is all green.

@acstll acstll requested a review from felix-ico April 17, 2023 13:16
@acstll acstll requested a review from nowseemee as a code owner April 17, 2023 13:16
@netlify
Copy link

netlify bot commented Apr 17, 2023 •
edited
Loading

✅ Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit ffc96ac
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/643d495c7732970008804a5b
😎 Deploy Preview https://deploy-preview-1729--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot mentioned this pull request Apr 17, 2023
Closed
felix-ico
felix-ico approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@felix-ico felix-ico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@acstll acstll merged commit d1ed031 into main Apr 17, 2023
@acstll acstll deleted the fix/tab-nav-focus-1372 branch April 17, 2023 14:07
@acstll acstll mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix-ico felix-ico felix-ico approved these changes

@nowseemee nowseemee Awaiting requested review from nowseemee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scale-tab-nav always graps tab nav
2 participants
@acstll @felix-ico