Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add placeholder prop in date picker #1720

Merged
merged 4 commits into from
Apr 14, 2023
Merged

feat: add placeholder prop in date picker #1720

merged 4 commits into from
Apr 14, 2023

Conversation

ayeshaa-m
Copy link
Contributor

Added placeholder property in date picker component

@ayeshaa-m ayeshaa-m requested a review from acstll as a code owner April 12, 2023 09:07
@ayeshaa-m ayeshaa-m linked an issue Apr 12, 2023 that may be closed by this pull request
Add placeholder for datepicker (React) #1638
Closed
@ayeshaa-m ayeshaa-m requested a review from nowseemee as a code owner April 12, 2023 09:07
@netlify
Copy link

netlify bot commented Apr 12, 2023 •
edited
Loading

✅ Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 962a09f
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/64392fa4b0f3c70008d3a284
😎 Deploy Preview https://deploy-preview-1720--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot mentioned this pull request Apr 13, 2023
Closed
@ayeshaa-m
Copy link
Contributor Author

fixed console issues as well.
Screenshot 2023-04-14 at 4 28 24 PM

nowseemee
nowseemee approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@nowseemee nowseemee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's great, chef, thank you!

@ayeshaa-m ayeshaa-m merged commit 335c78f into main Apr 14, 2023
@ayeshaa-m ayeshaa-m deleted the feat/datepicker-1638 branch April 14, 2023 11:37
@ayeshaa-m ayeshaa-m self-assigned this May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nowseemee nowseemee nowseemee approved these changes

@acstll acstll Awaiting requested review from acstll

Assignees

@ayeshaa-m ayeshaa-m

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add placeholder for datepicker (React)
2 participants
@ayeshaa-m @nowseemee