Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix footer not taking full width of container #1714

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

ayeshaa-m
Copy link
Contributor

removed max-width property

@ayeshaa-m ayeshaa-m requested a review from acstll as a code owner April 10, 2023 07:09
@ayeshaa-m ayeshaa-m requested a review from nowseemee as a code owner April 10, 2023 07:09
@netlify
Copy link

netlify bot commented Apr 10, 2023

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 9c203e9
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/6437aeae1c343600082a1559
😎 Deploy Preview https://deploy-preview-1714--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ayeshaa-m ayeshaa-m self-assigned this Apr 11, 2023
@ayeshaa-m ayeshaa-m requested review from felix-ico and removed request for acstll April 11, 2023 07:15
@felix-ico
Copy link
Collaborator

@ayeshaa-m I think the max-width is actually needed here, in order to make the footer align with the rest of the "grid" (if you check you will find that --scl-grid-max-width is also used in the header, to keep everything the same size)...so I think we need to double check this, maybe setting up a little app-shell and see how it looks when resizing (you can ping me about this for details).

If we end up removing this, I would also remove the private variable --_max-width-container since it would not be used anywhere else in the component.

@ayeshaa-m ayeshaa-m requested review from acstll and removed request for nowseemee April 11, 2023 10:45
@felix-ico
Copy link
Collaborator

I just tested it out in chrome and ff, chrome looks good but on FF the footer content isn't yet aligned to the header

CHROME:
Screenshot 2023-04-12 at 11 43 00

FF:
Screenshot 2023-04-12 at 11 43 19

Copy link
Collaborator

@felix-ico felix-ico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayeshaa-m ayeshaa-m merged commit a17e9df into main Apr 13, 2023
@ayeshaa-m ayeshaa-m deleted the fix/scale-telekom-footer-1700 branch April 13, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scale-telekom-footer (Beta-component) content doesn't take all its area
2 participants