-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix footer not taking full width of container #1714
Conversation
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@ayeshaa-m I think the max-width is actually needed here, in order to make the footer align with the rest of the "grid" (if you check you will find that --scl-grid-max-width is also used in the header, to keep everything the same size)...so I think we need to double check this, maybe setting up a little app-shell and see how it looks when resizing (you can ping me about this for details). If we end up removing this, I would also remove the private variable |
packages/components/src/components/telekom/telekom-footer/telekom-footer-content.css
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
removed max-width property