Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace footnote token #1696

Merged
merged 4 commits into from
Mar 31, 2023
Merged

fix: replace footnote token #1696

merged 4 commits into from
Mar 31, 2023

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Mar 30, 2023

  • replace --telekom-typography-font-size-footnote with new --telekom-typography-font-size-badge
  • remove --telekom-typography-font-size-footnote leftovers in Storybook
  • update "font formats" image in Guidelines/Typography removing 10px size

Updating the telekom/design-tokens package will follow after telekom/design-tokens#199 is merged and released.

@acstll acstll requested a review from nowseemee as a code owner March 30, 2023 10:13
@netlify
Copy link

netlify bot commented Mar 30, 2023 •
edited
Loading

✅ Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 44a7b8a
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/64256b2a7b1c4e000879d51f
😎 Deploy Preview https://deploy-preview-1696--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot mentioned this pull request Mar 30, 2023
Merged
marvinLaubenstein
marvinLaubenstein approved these changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@marvinLaubenstein marvinLaubenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@acstll acstll merged commit a33843f into main Mar 31, 2023
@acstll acstll deleted the fix/remove-footnote-token branch March 31, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinLaubenstein marvinLaubenstein marvinLaubenstein approved these changes

@nowseemee nowseemee Awaiting requested review from nowseemee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acstll @marvinLaubenstein