fix: reset pagination to last page if new records are rendered are less than previous #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot one first page
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ayeshaa-m
requested review from
felix-ico and
marvinLaubenstein
and removed request for
acstll
nowseemee
approved these changes
Mar 24, 2023
marvinLaubenstein
approved these changes
Mar 24, 2023
|
Hi @ayeshaa-m I'm thinking if we should make this feature optional? I know that some users programmatically add rows to a data grid (for example by populating the data grid with API responses)... currently this implementation would go back to the first page every time a new row is added to the data-grid. What do you think? |
|
@felix-ico Good point. We should make it optional |
…rds are less than previous
|
@felix-ico @acstll As discussed, the pagination is set to last page if new records are less than the previous records count. |
ayeshaa-m
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reset pagination start point