fix: fix style issue in data-grid pagination #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ayeshaa-m
requested review from
felix-ico and
marvinLaubenstein
and removed request for
acstll and
nowseemee
Co-authored-by: ayeshaa-m <[email protected]>
|
Hi @ayeshaa-m, in cases like this we would need to ask one of our designers if it is OK to implement as the user suggests, as this is fundamentally just a design change. We would also need to update the sketch and figma libraries for consistency, if we merge this. |
Co-authored-by: ayeshaa-m <[email protected]>
|
@felix-ico @marvinLaubenstein Got confirmation from Florian, 44px is fine. Once PR is approved, this can be merged. |
marvinLaubenstein
approved these changes
Mar 21, 2023
|
LGTM 🤓 |
felix-ico
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix style as per suggestion in the bug.