Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-navigation-main-mobile): second level if no children (actual child element) #1660

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Mar 16, 2023

Follow up to #1612. Should finally fix #1402 🙏

@acstll acstll requested a review from nowseemee as a code owner March 16, 2023 12:03
@netlify
Copy link

netlify bot commented Mar 16, 2023

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 087612b
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/641305a9c9abb2000849de2b
😎 Deploy Preview https://deploy-preview-1660--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@acstll
Copy link
Collaborator Author

acstll commented Mar 16, 2023

@marvinLaubenstein whenever you get a chance, please check this one out 🙏

Copy link
Collaborator

@marvinLaubenstein marvinLaubenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🤓, Thanks for finding the solution 🙂

@acstll acstll merged commit ccc5749 into main Mar 16, 2023
@acstll acstll deleted the fix/childmenu-1402 branch March 16, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile menu icon label + unnecessary 2nd level of navigation
2 participants