Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app-navigation-main-mobile): second level if no children #1612

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Feb 22, 2023

Should fix #1402

@acstll acstll requested a review from nowseemee as a code owner February 22, 2023 14:21
@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 7d816d9
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/63f624dd0a60790007423a5d
😎 Deploy Preview https://deploy-preview-1612--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@acstll
Copy link
Collaborator Author

acstll commented Feb 22, 2023

@nowseemee chef, would you be so kind to take a look at this one? 🪄

Copy link
Collaborator

@nowseemee nowseemee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@acstll acstll merged commit 88e0cd2 into main Feb 23, 2023
@acstll acstll deleted the fix/header-mobile-menu-1402 branch February 23, 2023 09:45
@sulyok-daniel
Copy link

I think the issue is still not solved in 3.0.0-beta.126.

The menu items are correctly recognized having no children - as can be seen at the aria-haspopup="false" attribute - in (1), but still we have to do an unneccessary click in (2) to get back to the main menu.

image
image

@acstll
Copy link
Collaborator Author

acstll commented Mar 16, 2023

@sulyok-daniel you're completely right this is not completely fixed. I'm really sorry for the inconvenience. We're at it now to get it properly and 100% fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile menu icon label + unnecessary 2nd level of navigation
3 participants