Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tab-header): unsafe querySelector #1608

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Feb 21, 2023

Should fix #1587

@felix-ico please 👀

@acstll acstll requested a review from nowseemee as a code owner February 21, 2023 16:03
@netlify
Copy link

netlify bot commented Feb 21, 2023

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit cc4c4aa
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/63f74381b75e7400086833a8
😎 Deploy Preview https://deploy-preview-1608--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@acstll
Copy link
Collaborator Author

acstll commented Feb 21, 2023

I guess this could have been adding ? to this.container?.querySelector('slot') but querying the slot itself was unnecessary I think…

@acstll acstll requested a review from felix-ico February 23, 2023 09:51
@acstll acstll merged commit 82d0f14 into main Feb 24, 2023
@acstll acstll deleted the fix/tab-header-slot-mani-1587 branch February 24, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in tab-nav - handling of "selected" leads to JS error of undefined
2 participants