Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: link targets in main navigation #1602

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Conversation

niklaswa
Copy link
Contributor

Small extension of #1592. Forgot one place for the link target 😅

@netlify
Copy link

netlify bot commented Feb 20, 2023

Deploy Preview for marvelous-moxie-a6e2fe ready!

Name Link
🔨 Latest commit 9f72bcd
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/63f3806ba2f7f30008b9b576
😎 Deploy Preview https://deploy-preview-1602--marvelous-moxie-a6e2fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@niklaswa niklaswa changed the title Link targets feat: link targets in main navigation Feb 20, 2023
Copy link
Collaborator

@nowseemee nowseemee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @niklaswa thanks for the PR!!! 🎉🎉🎉

Could you please run the unit tests and commit the updated snapshots? Also, will you please run the build script in the components folder and commit the updated readme.md?

Many thanks && looking forward to shipping this nice addition.

@nowseemee nowseemee merged commit bfda3aa into telekom:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants