fix: no value is set in DropdownSelect and SegmentedButton when using vue-router #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Could someone please review and merge this? Our development Team has been having these issues and it seems like this fix is available for quite some time now. |
nowseemee
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like mentonied in an issue before, the vue-router package make some problems with Scale (#1194).
In our project we have found two new problems:
For the first point I have two Sandboxes, one with using vue-router and one without it.
Sandbox 1: DropdownSelect with using vue-router
Sandbox 1: DropdownSelect without vue-router
For the second point, there is one Sandbox in my linked issue (#1580).
The behaviour is by both the same. It looks like the vue-router package don't allow using the method
getAttribute()andhasAttribute(), so the return value for it isnullor""(empty string). With the code in this PR the problem is fixed for our project and potentially all users who use the vue-router package or something similiar.