fix: add disabled link option #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://telekom-scale-storybook-preview-pr-1430.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cee8o294reb3l3t1o790. |
|
this should fix #1427 however I don't know if we want to support disabled links in general? good article about this topic https://www.scottohara.me/blog/2021/05/28/disabled-links.html |
|
@acstll could you check this one? also re: the above comment |
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
acstll
requested changes
Feb 8, 2023
There was a problem hiding this comment.
Hey, I wouldn't be in favor of allowing disabled links but since it's doable without much hassle, I think we can. Also the article you posted is great 🙌.
You almost had it, I'm suggesting a few changes only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.