feat(dropdown-select): add name prop
#1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://telekom-scale-storybook-preview-pr-1417.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ceca3harrk0fkimdqt00. |
acstll
force-pushed
the
fix/dropdown-select-name-1360
branch
from
40964d0 to
00e3c64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1360.
This is exclusively only adding the prop to
<scale-dropdown-select>. So when you listen for thescale-changeevent you can useevent.target.name.@filipjnc I think a hidden input element would be best added by yourself as a sibling of the Dropdown Select. If we put it inside the shadow DOM it will have no effect on form submission.
In the near future we could use
ElementInternalsto make "form associated" components. It's currently not supported by Safari, thou there's a polyfill. A there's also other ways to do it. It's —as always— just a matter of prios…@felix-ico would you be so kind to review this one?