Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add autocomplete-property to Scale-TextField #1400

Merged
merged 4 commits into from
Dec 2, 2022
Merged

add autocomplete-property to Scale-TextField #1400

merged 4 commits into from
Dec 2, 2022

Conversation

niclas18
Copy link
Contributor

@niclas18 niclas18 commented Dec 2, 2022

close my issue #1358

nowseemee
nowseemee reviewed Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@nowseemee nowseemee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!!! 🎉🎉🎉

Could you add the new prop to Storybook too, please?

  • scale/packages/storybook-vue/stories/components/text-field/ScaleTextField.vue
  • scale/packages/storybook-vue/stories/components/text-field/TextField.stories.mdx

packages/components/src/components/text-field/text-field.tsx Outdated Show resolved Hide resolved
@nowseemee
Copy link
Collaborator

Many thanks for your contribution, @niclas18! We'll release it early next week.

@nowseemee nowseemee merged commit 24f064d into telekom:main Dec 2, 2022
@niclas18 niclas18 mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nowseemee nowseemee nowseemee left review comments

@acstll acstll Awaiting requested review from acstll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niclas18 @nowseemee