-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent focus on first render #1383
Conversation
Your Render PR Server URL is https://telekom-scale-storybook-preview-pr-1383.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cdvkbven6mpuuvmtvhi0. |
fixes #1372. not sure if the new prop |
@acstll could you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @felix-ico thanks for taking care of this one! It's working as expected now 👍 …but I think we shouldn't be exposing a firstRender
attribute in Tab Header, it doesn't seem useful for consumers 🤔 — Could we make this something internal?
@acstll i removed the stencil prop and used a regular attribute instead, seems to work as expected. |
Co-authored-by: felix-ico <[email protected]>
Co-authored-by: felix-ico <[email protected]>
Co-authored-by: felix-ico <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
No description provided.