Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helper-text): styles #1351

Merged
merged 4 commits into from
Nov 4, 2022
Merged

fix(helper-text): styles #1351

merged 4 commits into from
Nov 4, 2022

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Nov 4, 2022

  • icon position: handle multiline (top)
  • hopefully better icon placement/alignment
  • text-align always left
  • add variant to Dropdown Select (informational default)

@nowseemee please 👁️

@acstll acstll requested a review from nowseemee as a code owner November 4, 2022 16:27
@render
Copy link

render bot commented Nov 4, 2022

Your Render PR Server URL is https://telekom-scale-storybook-preview-pr-1351.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cdijqskgqg4atkjobavg.

@github-actions github-actions bot mentioned this pull request Nov 4, 2022
Merged
@acstll acstll merged commit ca8ad1c into main Nov 4, 2022
@acstll acstll deleted the fix/helper-text-styles branch November 4, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nowseemee nowseemee Awaiting requested review from nowseemee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@acstll