Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion): deal only with direct collapsible children #1243

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Oct 5, 2022

Fixes #1232 /cc @Lalaluka (alternative to #1240)

@nowseemee please have a quick look 👁️

@acstll acstll requested a review from nowseemee as a code owner October 5, 2022 10:34
@render
Copy link

render bot commented Oct 5, 2022

Copy link
Contributor

@Lalaluka Lalaluka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks a bit cleaner than mine.

@acstll acstll merged commit 19a137b into main Oct 5, 2022
@acstll acstll deleted the fix/accordion-children-1232 branch October 5, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two Accordions inside of each other ignore level-heading
3 participants