Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(slider): mobile 📱 #1221

Merged
merged 17 commits into from
Sep 27, 2022
Merged

refactor(slider): mobile 📱 #1221

merged 17 commits into from
Sep 27, 2022

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Sep 22, 2022 •
edited
Loading

Replaces #1174

  • multi-thumb aka range
  • deprecate props trackSmall, etc.
  • update styles (use part selector [attr~=value])
  • styles for Android and iOS
  • show "hash marks"
  • helper text
  • storybook
  • visual tests update 😵‍💫

@acstll acstll requested a review from nowseemee as a code owner September 22, 2022 07:47
@render
Copy link

render bot commented Sep 22, 2022

Your Render PR Server URL is https://telekom-scale-storybook-preview-pr-1221.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-ccm16c9a6gdj1l246akg.

@reld
Copy link
Collaborator

reld commented Sep 22, 2022

Nice! 🥷

@acstll acstll changed the base branch from main to preview/mobile-update-1 September 27, 2022 09:40
@acstll acstll added the preview label Sep 27, 2022
@acstll acstll merged commit 3fd61af into preview/mobile-update-1 Sep 27, 2022
@acstll acstll deleted the refactor/slider-mobile-2 branch September 27, 2022 10:00
nowseemee pushed a commit that referenced this pull request Oct 6, 2022
@nowseemee
feat(slider): mobile optimisation (#1221)
3797bfd
nowseemee pushed a commit that referenced this pull request Oct 6, 2022
@nowseemee
feat(slider): mobile optimisation (#1221)
7276d15
nowseemee pushed a commit that referenced this pull request Oct 6, 2022
@nowseemee
feat(slider): mobile optimisation (#1221)
5d39d2d
nowseemee pushed a commit that referenced this pull request Oct 27, 2022
@nowseemee
feat(slider): mobile optimisation (#1221)
5d41da7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nowseemee nowseemee Awaiting requested review from nowseemee

Assignees
No one assigned
Labels
preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acstll @reld