Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add displayCloseButton prop, update storybook #1197

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Conversation

maomaoZH
Copy link
Collaborator

@maomaoZH maomaoZH commented Sep 7, 2022

No description provided.

@maomaoZH maomaoZH requested a review from acstll September 7, 2022 11:16
@maomaoZH maomaoZH requested a review from nowseemee as a code owner September 7, 2022 11:16
@render
Copy link

render bot commented Sep 7, 2022

Copy link
Collaborator

@acstll acstll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than changes I'm making questions 🙏 — thanks for the PR!

packages/components/src/components/modal/modal.tsx Outdated Show resolved Hide resolved
packages/components/src/components/modal/modal.tsx Outdated Show resolved Hide resolved
Arturo Castillo Delgado and others added 4 commits September 12, 2022 09:52
* docs: update docs for vue+vite

* fix: format

* fix: make vue samples consisten with each other (styling)

* fix: make vue samples consisten with each other (styling)
@acstll
Copy link
Collaborator

acstll commented Sep 12, 2022

All good! 👍

@maomaoZH maomaoZH merged commit 2e7898b into main Sep 12, 2022
@maomaoZH maomaoZH deleted the fix/improve-modal branch September 12, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants