fix(dropdown-select-item): reflect value prop
#1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://telekom-scale-storybook-preview-pr-1196.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-ccc5n6pa6gdoobj2ljr0. |
|
thank you @nowseemee, whenever you're ready 🚀 |
maomaoZH
pushed a commit
that referenced
this pull request
Sep 12, 2022
maomaoZH
added a commit
that referenced
this pull request
Sep 12, 2022
* fix: add displayCloseButton prop, update storybook * fix(dropdown-select-item): reflect value prop, fixes #1194 (#1196) * docs: update docs for vue+vite (#1195) * docs: update docs for vue+vite * fix: format * fix: make vue samples consisten with each other (styling) * fix: make vue samples consisten with each other (styling) * chore(release): publish * fix: update prop name of hide modal close button Co-authored-by: Maomao Meyer-Zhang <[email protected]> Co-authored-by: Arturo Castillo Delgado <[email protected]> Co-authored-by: felix-ico <[email protected]> Co-authored-by: Daniel Beck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1194
@nowseemee please take a look 🙏