refactor(notification): 3 into 1 #1180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
May 23, 2023 12:29
acstll
force-pushed
the
refactor/a11y-notification
branch
from
293a1c0 to
9c577f3
Compare
✅ Deploy Preview for marvelous-moxie-a6e2fe ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
added 2 commits
May 23, 2023 16:31
…1882) * test(visual): update snapshots * fix: wrong snapshot --------- Co-authored-by: acstll <[email protected]> Co-authored-by: Arturo <[email protected]>
|
Merging now the refactor only, will do a11y later on… |
acstll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines Notification Banner, Message and Toast into a single Notification component.
keyboard interaction