Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(callout): a11y 💙 #1175

Merged
merged 13 commits into from
Sep 29, 2022
Merged

refactor(callout): a11y 💙 #1175

merged 13 commits into from
Sep 29, 2022

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Aug 18, 2022 •
edited
Loading

  • right tokens
  • keyboard interaction
  • ARIA roles, states and props
  • stories make sense (nothing overly complicated, nothing superficial)
  • has usage text (draft)

@acstll acstll added the accessibility Related to accessibility label Aug 18, 2022
@render
Copy link

render bot commented Aug 18, 2022

Your Render PR Server URL is https://telekom-scale-storybook-preview-pr-1175.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cbv3tbkgqg4ejjhecjtg.

@acstll acstll changed the base branch from main to preview/mobile-update-1 September 29, 2022 11:56
@acstll acstll marked this pull request as ready for review September 29, 2022 11:56
@acstll acstll requested a review from nowseemee as a code owner September 29, 2022 11:56
@acstll acstll merged commit 465a974 into preview/mobile-update-1 Sep 29, 2022
@acstll acstll deleted the refactor/a11y-callout branch September 29, 2022 11:57
nowseemee pushed a commit that referenced this pull request Oct 6, 2022
@nowseemee
feat(callout): refactor, improve accessibility (#1175)
5159a3a
nowseemee pushed a commit that referenced this pull request Oct 6, 2022
@nowseemee
feat(callout): refactor, improve accessibility (#1175)
574c5ed
nowseemee pushed a commit that referenced this pull request Oct 6, 2022
@nowseemee
feat(callout): refactor, improve accessibility (#1175)
b44f145
nowseemee pushed a commit that referenced this pull request Oct 27, 2022
@nowseemee
feat(callout): refactor, improve accessibility (#1175)
1aab1c2
nowseemee pushed a commit that referenced this pull request Oct 27, 2022
@nowseemee
feat(callout): refactor, improve accessibility (#1175)
23f4b8a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nowseemee nowseemee Awaiting requested review from nowseemee

Assignees
No one assigned
Labels
accessibility Related to accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@acstll