Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tooltip): a11y 💙 #1170

Merged
merged 5 commits into from
Feb 10, 2023
Merged

refactor(tooltip): a11y 💙 #1170

merged 5 commits into from
Feb 10, 2023

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Aug 16, 2022 •
edited
Loading

https://www.w3.org/WAI/ARIA/apg/patterns/tooltip/

  • right tokens
  • keyboard interaction
  • ARIA roles, states and props
  • stories make sense (nothing overly complicated, nothing superficial)
  • has usage text

@acstll acstll added the accessibility Related to accessibility label Aug 16, 2022
@render
Copy link

render bot commented Aug 16, 2022

Your Render PR Server URL is https://telekom-scale-storybook-preview-pr-1170.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cbtrebcgqg49fvlqe1gg.

@acstll acstll mentioned this pull request Sep 28, 2022
Closed
@netlify
Copy link

netlify bot commented Feb 10, 2023 •
edited
Loading

❌ Deploy Preview for marvelous-moxie-a6e2fe failed.

Name Link
🔨 Latest commit 749af87
🔍 Latest deploy log https://app.netlify.com/sites/marvelous-moxie-a6e2fe/deploys/63e65935ad6ff8000824886f

@acstll acstll marked this pull request as ready for review February 10, 2023 14:48
@acstll acstll requested a review from nowseemee as a code owner February 10, 2023 14:48
@acstll
Copy link
Collaborator Author

acstll commented Feb 10, 2023

Merging the fix without removing the beta label yet. Another PR will follow. Should fix #1225.

@acstll acstll merged commit 33571f7 into main Feb 10, 2023
@acstll acstll deleted the refactor/a11y-tooltip branch February 10, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nowseemee nowseemee Awaiting requested review from nowseemee

Assignees
No one assigned
Labels
accessibility Related to accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@acstll