Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): a few issues #1165

Merged
merged 18 commits into from
Aug 16, 2022
Merged

fix(tooltip): a few issues #1165

merged 18 commits into from
Aug 16, 2022

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Aug 8, 2022

  • use trigger element (child inside slot) for events, and not the host itself, to avoid margins triggering the tooltip
  • warn if used without a trigger element (just text, wrong usage)
  • add beta notice
  • fix jump when visible early (the element was visible before it was positioned)
  • use pointer-events: none when hidden, to avoid interfering
  • rename open to opened for consistency with other components (Modal et al) — ⚠️ breaking

@nowseemee if you're so kind 👀 — @marvinLaubenstein please also take a look if you have time 🙏

@acstll acstll requested a review from nowseemee as a code owner August 8, 2022 14:15
@render
Copy link

render bot commented Aug 8, 2022

Copy link
Collaborator

@marvinLaubenstein marvinLaubenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice 🙂, but shouldn't the prop renaming from open to opened also be in the storybook ?

nice catch 🙌 — I completely forgot

Copy link
Collaborator

@nowseemee nowseemee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding these! 🙌🏻

@acstll
Copy link
Collaborator Author

acstll commented Aug 10, 2022

I need yer help @nowseemee 🤠

image

@nowseemee
Copy link
Collaborator

I need yer help @nowseemee 🤠

image

on it 🤠

@acstll acstll merged commit 4656a51 into main Aug 16, 2022
@acstll acstll deleted the fix/tooltip-issues branch August 16, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants