Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu-flyout): properly close sublists #1131

Merged
merged 4 commits into from
Jul 11, 2022
Merged

Conversation

acstll
Copy link
Collaborator

@acstll acstll commented Jul 8, 2022

Fixes #712 and #1122

@acstll acstll requested a review from marvinLaubenstein July 8, 2022 14:28
@acstll acstll requested a review from nowseemee as a code owner July 8, 2022 14:28
@render
Copy link

render bot commented Jul 8, 2022

@acstll acstll force-pushed the fix/flyout-overlap-712 branch from a085484 to 60caf45 Compare July 8, 2022 14:34
@acstll
Copy link
Collaborator Author

acstll commented Jul 8, 2022

@marvinLaubenstein you may take a look again 🙏 (hopefully the preview link works at some point) — thanks again for spotting the bug in the previous PR!

@marvinLaubenstein
Copy link
Collaborator

⚠️ Visual tests seem to have problems in connection with the current changes

@acstll
Copy link
Collaborator Author

acstll commented Jul 11, 2022

Hopefully it's good now… (@marvinLaubenstein you can test locally with yarn dev at /flyout-menu.html)

@marvinLaubenstein
Copy link
Collaborator

Everything seems to work 🙂

@acstll acstll merged commit b47d6e9 into main Jul 11, 2022
@acstll acstll deleted the fix/flyout-overlap-712 branch July 11, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlap and focus errors in the flyout menu
2 participants