From 789b78928e9a72e7470dba9833d7cbab4c443a73 Mon Sep 17 00:00:00 2001 From: Arturo Date: Tue, 23 May 2023 13:18:21 +0200 Subject: [PATCH] fix(notification): placement of closeButtonLabel and closeButtonTitle (see #1694) --- .../src/components/notification/notification.css | 2 +- .../src/components/notification/notification.tsx | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/packages/components/src/components/notification/notification.css b/packages/components/src/components/notification/notification.css index 76d3eb87a4..ce6130d922 100644 --- a/packages/components/src/components/notification/notification.css +++ b/packages/components/src/components/notification/notification.css @@ -117,7 +117,7 @@ [part~='base'] { border: 1px solid white; } - + [part='close-button'] { --color-ghost: white; } diff --git a/packages/components/src/components/notification/notification.tsx b/packages/components/src/components/notification/notification.tsx index e7171860dc..98e4837fc4 100644 --- a/packages/components/src/components/notification/notification.tsx +++ b/packages/components/src/components/notification/notification.tsx @@ -141,11 +141,14 @@ export class Notification { part="close-button" variant="ghost" onClick={this.close} - aria-label={this.closeButtonLabel} - title={this.closeButtonTitle} > - + )}