Allow disabling of SSL certificate verification; Adds Branch-Tag description to engagement test #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cription to engagement
szEvEz
requested changes
Nov 24, 2024
| | `defectDojoEvalTestTitle` | `"false"` | Specifies whether the test title should be evaluated as a python function. | | ||
| | `defectDojoMinimumSeverity` | `Info` | The minimum severity level for findings in DefectDojo. | | ||
| | `defectDojoProductName` | `product` | The name of the product in DefectDojo. | | ||
| | `defectDojoProductTypeName` | `Research and Development` | The type of the product in DefectDojo. | | ||
| | `defectDojoEnvName` | `Development` | The type of the env in DefectDojo. | | ||
| | `defectDojoBranchTag` | `branch-tag` | The name of the Branch/Tag to be specified in DefectDojo. | |
There was a problem hiding this comment.
I think it would be better to name this something like defectDojoGitRef, with specific examples on what can be handed over here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified Problems
send_to_dojomethod that publishes findings to an engagement on Defect Dojo fails on networks where Defect Dojo doesn't have a verifiable SSL certificate.Proposed Solutions
send_to_dojomethod. If nothing is specified the validation should be enabled.